Skip to content

Adds support for the borderless frame#15

Merged
kvendrik merged 16 commits intorelease/1.0.0-alphafrom
fix/borderless-frame-support
Dec 6, 2018
Merged

Adds support for the borderless frame#15
kvendrik merged 16 commits intorelease/1.0.0-alphafrom
fix/borderless-frame-support

Conversation

@kvendrik
Copy link
Owner

@kvendrik kvendrik commented Nov 4, 2018

Adds support for borderless and notification frame.

fixes #4

@kvendrik kvendrik changed the base branch from master to release/1.0.0-alpha November 4, 2018 22:56
@kvendrik kvendrik merged commit 3ffb70a into release/1.0.0-alpha Dec 6, 2018
@kvendrik kvendrik deleted the fix/borderless-frame-support branch December 6, 2018 20:15
kvendrik added a commit that referenced this pull request Dec 6, 2018
* cleans up the interface

* updates lodash-decorators

* makes user optional

* corrects minor typo

* fixes minor typo

* Adds support for the borderless frame (#15)

* adds support for borderless frame

* updates playground ts config

* adds notification frame and hidden launcher support

* adds note to readme

* adds ⚠️  emoji

* adds link to installation instructions

* fixes typos

* fixes build errors

* fixes tests

* adds missing tests

* adds missing tests

* replaces mocks with noops

* fixes type issue

* fixes type issue

* rm js utils

* increments max bundle size

* updates version in readme

* bumped build
@coveralls
Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 47

  • 35 of 66 (53.03%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-16.5%) to 75.117%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/ImportIsolatedRemote/ImportIsolatedRemote.tsx 3 5 60.0%
src/utilities/injectCustomStyles.ts 1 5 20.0%
src/components/BorderlessFrameListener/BorderlessFrameListener.ts 4 29 13.79%
Totals Coverage Status
Change from base Build 37: -16.5%
Covered Lines: 119
Relevant Lines: 153

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants