-
Notifications
You must be signed in to change notification settings - Fork 1
feat(reports): create member status report #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…alize and export all members in the system
…auses ui quirk on the new version of datatables
IanEdington
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really able to review this PR effectively given it's size.
It looks like there are multiple parts to this PR. Maybe one that's removing existing reports(?) and another that's adding a report. Or migrating from datatables to another tool?
I'm also not clear how changing gatekeeper is related to reports.
I'm happy for you to merge this if you're confident in the changes and don't need a review
|
Sure. I'd rather you read through and approve based on merit. If you read the files by commit instead of all at once, they tell a story. The first commit builds a page that allows access to a list of various reports, a member status report, and a view to render report data in tabular form. The view uses a later version of data tables pulled in directly from CDN. The next commit removes the references to the CDN and copies the needed files to The final commit gets rid of every Ignore the files tab. Just look through the changes per commit instead. If you want to test it out, just checkout this branch locally and play with it. |
Kpapadak1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved
This PR roughs in a super basic reports mechanism for accessing predefined reports. Reports can be accessed by users with the
can:manage-reportsrole and currently only one report is available. The Member Status report defined in #53 . This report mechanism utilizes the datatables library but more specifically the export function provided as part of the buttons extension. This enables the table to export its data to a paste, CSV, XLSX, or printed document all from within the browser.During the process of creating this feature, I updated the version of datatables used as well as the way it was imported. There were many broken import statements leading to a script resource location that didn't exist. Additionally, there's a UI quirk with the new version where margin is removed if there exists a
div.table-responsivewrapper around the table. This wrapper is used in base Bootstrap 4 to make tables responsive and scrollable in the horizontal axis. However when using the datatable library, this functionality is broken and implemented in a different way. For these reasons, I have removeddiv.table-responsivewrappers for every table in the application and verified no change in appearance or function.List of reports:

Member status report:

Report being printed:
