-
Notifications
You must be signed in to change notification settings - Fork 7
Add RSpec 'let' and 'let!' variable capture to scope parser #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix visibility of 'let' variables in RSpec tests
Add RSpec 'let' and 'let!' variable capture to scope parser
Dec 31, 2025
…kwerle/ruby_language_server into copilot/fix-rspec-let-variables-display
kwerle
reviewed
Dec 31, 2025
| end | ||
|
|
||
| # let! is an eager version of let that is evaluated immediately | ||
| def method_missing(method_name, *args, &block) |
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make this an alias of on_let_command.
kwerle
reviewed
Dec 31, 2025
| end | ||
| end | ||
|
|
||
| def respond_to_missing?(method_name, include_private = false) |
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this should no longer be needed?
kwerle
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSpec
letandlet!variable declarations were not being captured by the scope parser, preventing code completion and navigation for these variables in test files.Changes
on_let_commandhandler inRspecCommandsmodule to extract variable names fromlet(:name)syntax and register them in the current scopelet!support viamethod_missingto handle the eager evaluation variant (method names with!require special handling)letandlet!variables in top-level and nested describe/context blocksExample
Variables are scoped within their containing describe/context blocks, matching RSpec's scoping semantics.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.