Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 31, 2025

The GitHub Actions test workflow was manually invoking docker commands instead of using the standardized make test target defined in the Makefile.

Changes:

  • Replaced three separate workflow steps (build, test, rubocop) with single make test invocation
  • This ensures CI uses the same test command as local development
  • make test handles image build, volume mounting, and runs both bundle exec rake test and bundle exec rubocop

Before:

- name: build
  run: make image
- name: test
  run: docker run --rm ruby_language_server rake | tee test.log
- name: rubocop
  run: docker run --rm ruby_language_server rubocop | tee rubocop.log

After:

- name: Run tests
  run: make test
Original prompt

This section details on the original issue you should resolve

<issue_title>github does not run the tests</issue_title>
<issue_description>github should run the tests on push. make test</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix GitHub actions to run tests on push Use make test in GitHub Actions workflow Dec 31, 2025
Copilot AI requested a review from kwerle December 31, 2025 00:51
@kwerle kwerle marked this pull request as ready for review December 31, 2025 01:04
@kwerle kwerle merged commit 4f22948 into develop Dec 31, 2025
3 checks passed
@kwerle kwerle deleted the copilot/fix-github-tests-running branch December 31, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github does not run the tests

2 participants