Fix macOS build: use #if instead of #ifdef for TARGET_OS checks#9
Open
timredfern wants to merge 1 commit intokylemcdonald:masterfrom
Open
Fix macOS build: use #if instead of #ifdef for TARGET_OS checks#9timredfern wants to merge 1 commit intokylemcdonald:masterfrom
timredfern wants to merge 1 commit intokylemcdonald:masterfrom
Conversation
TARGET_OS_IPHONE and TARGET_OS_MAC are defined as 0 or 1, not just defined/undefined. Using #ifdef causes the wrong branch to be taken on macOS since TARGET_OS_IPHONE is defined (as 0). This fixes the "MobileCoreServices/MobileCoreServices.h not found" error when building on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building on macOS fails with:
Cause
The preprocessor checks in
audiodecodercoreaudio.huse#ifdef TARGET_OS_IPHONEand#elif defined TARGET_OS_MAC. However, these macros are defined as 0 or 1 in Apple'sTargetConditionals.h, not just defined/undefined.On macOS,
TARGET_OS_IPHONEis defined as 0, so#ifdef TARGET_OS_IPHONEevaluates to true (because the macro exists), causing the iOS header to be included instead of the macOS one.Fix
Change
#ifdefto#ifso the value is checked rather than just existence:Tested on macOS 15 with openFrameworks 0.12.1.