Skip to content

refactor the ApplySpecifiedModules func #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kyma-bot merged 1 commit into from
Aug 20, 2024
Merged

refactor the ApplySpecifiedModules func #2207

kyma-bot merged 1 commit into from
Aug 20, 2024

Conversation

@pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Aug 16, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • refactor the ApplySpecifiedModules func and test it
  • apply module resources based on the community json content

Related issue(s)

@pPrecel pPrecel added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2024
@pPrecel pPrecel requested a review from a team as a code owner August 16, 2024 12:03
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 16, 2024
@pPrecel pPrecel marked this pull request as draft August 16, 2024 12:03
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2024
@pPrecel pPrecel marked this pull request as ready for review August 19, 2024 08:13
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
@pPrecel pPrecel added area/cli Related to all activities around CLI kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. labels Aug 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 20, 2024
@kyma-bot kyma-bot merged commit 6a7c96e into kyma-project:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cortey Cortey Cortey approved these changes

Assignees

@Cortey Cortey

Labels

area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pPrecel @Cortey @kyma-bot