Skip to content

Added the new Hana Map command that fulfills the new CLI requirements #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Cortey merged 1 commit into from
Nov 12, 2024
Merged

Added the new Hana Map command that fulfills the new CLI requirements #2242

Cortey merged 1 commit into from
Nov 12, 2024

Conversation

@Cortey
Copy link
Contributor

@Cortey Cortey commented Nov 8, 2024

Description
As in title

Related issue(s)
#2225

@Cortey Cortey requested a review from a team as a code owner November 8, 2024 14:10
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2024
@Cortey Cortey added area/cli Related to all activities around CLI kind/feature Categorizes issue or PR as related to a new feature. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Nov 8, 2024
halamix2
halamix2 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@halamix2 halamix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow
/pony
/joke
/woof

@kyma-bot
Copy link

kyma-bot commented Nov 12, 2024

@halamix2: Why couldn't the kid see the pirate movie? Because it was rated arrr!

Details

In response to this:

/meow
/pony
/joke
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot
Copy link

kyma-bot commented Nov 12, 2024

@halamix2: dog image

Details

In response to this:

/meow
/pony
/joke
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot
Copy link

kyma-bot commented Nov 12, 2024

@halamix2: cat image

Details

In response to this:

/meow
/pony
/joke
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 12, 2024
@kyma-bot
Copy link

kyma-bot commented Nov 12, 2024

@halamix2: pony image

Details

In response to this:

/meow
/pony
/joke
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Cortey Cortey merged commit 336782b into kyma-project:main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halamix2 halamix2 halamix2 approved these changes

Assignees

@halamix2 halamix2

Labels

area/cli Related to all activities around CLI kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cortey @kyma-bot @halamix2