Skip to content

Remove old modules-related commands and code #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pPrecel merged 1 commit into from
Nov 28, 2024
Merged

Remove old modules-related commands and code #2265

pPrecel merged 1 commit into from
Nov 28, 2024

Conversation

@pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Nov 28, 2024

Description

Changes proposed in this pull request:

  • remove old code because we have to re-implemented it due to new module catalog concept

Related issue(s)

@pPrecel pPrecel added area/ci Issues or PRs related to CI related topics kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 28, 2024
@pPrecel pPrecel requested a review from a team as a code owner November 28, 2024 11:55
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2024
halamix2
halamix2 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@halamix2 halamix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/pony

@kyma-bot
Copy link

kyma-bot commented Nov 28, 2024

@halamix2: pony image

Details

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 28, 2024
@pPrecel pPrecel merged commit 13b2856 into kyma-project:main Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halamix2 halamix2 halamix2 approved these changes

Assignees

@halamix2 halamix2

Labels

area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pPrecel @kyma-bot @halamix2