Skip to content

Add module disable command #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pPrecel merged 5 commits into from
Dec 17, 2024
Merged

Add module disable command #2282

pPrecel merged 5 commits into from
Dec 17, 2024

Conversation

@pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Dec 14, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • as in the title
  • fix the map.go file test

Related issue(s)

@pPrecel pPrecel added kind/feature Categorizes issue or PR as related to a new feature. area/cli Related to all activities around CLI labels Dec 14, 2024
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 14, 2024
@pPrecel pPrecel force-pushed the disable-module branch 3 times, most recently from 2cb55f6 to 128224d Compare December 17, 2024 08:18
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 17, 2024
@pPrecel pPrecel marked this pull request as ready for review December 17, 2024 10:30
@pPrecel pPrecel requested a review from a team as a code owner December 17, 2024 10:30
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@pPrecel pPrecel enabled auto-merge (squash) December 17, 2024 10:35
halamix2
halamix2 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@halamix2 halamix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/pony

@pPrecel pPrecel merged commit a4d9651 into kyma-project:main Dec 17, 2024
3 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 17, 2024
@kyma-bot
Copy link

kyma-bot commented Dec 17, 2024

@halamix2: pony image

Details

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halamix2 halamix2 halamix2 approved these changes

Assignees

@halamix2 halamix2

Labels

area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pPrecel @kyma-bot @halamix2