Skip to content

Improve parameters #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pPrecel merged 2 commits into from
Jan 27, 2025
Merged

Improve parameters #2333

pPrecel merged 2 commits into from
Jan 27, 2025

Conversation

@pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Jan 23, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • remove redundant code
  • reuse cmdcommon/types pkg
  • add tests

Related issue(s)

@pPrecel pPrecel added area/cli Related to all activities around CLI kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 23, 2025
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2025
@pPrecel pPrecel force-pushed the improve-parameters branch from 5f99399 to bcf07ca Compare January 24, 2025 14:47
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2025
@pPrecel pPrecel marked this pull request as ready for review January 24, 2025 14:48
@pPrecel pPrecel requested a review from a team as a code owner January 24, 2025 14:48
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2025
@pPrecel pPrecel enabled auto-merge (squash) January 27, 2025 19:25
@pPrecel pPrecel merged commit f585da9 into kyma-project:main Jan 27, 2025
8 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichalKalke MichalKalke MichalKalke approved these changes

Assignees

@MichalKalke MichalKalke

Labels

area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pPrecel @MichalKalke @kyma-bot