Skip to content

Support complex slices for extensions custom flags #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pPrecel merged 2 commits into from
Jan 28, 2025
Merged

Support complex slices for extensions custom flags #2335

pPrecel merged 2 commits into from
Jan 28, 2025

Conversation

@pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Jan 24, 2025

Description

Changes proposed in this pull request:

  • support custom flags complex slices paths like:
    • .spec.elem[].item
    • .spec.elem[2].item

Related issue(s)

@pPrecel pPrecel added kind/feature Categorizes issue or PR as related to a new feature. area/cli Related to all activities around CLI labels Jan 24, 2025
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2025
@pPrecel pPrecel added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/enhancement and removed kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jan 24, 2025
@pPrecel pPrecel force-pushed the extensions-support-slices branch from e4cf634 to 50ec257 Compare January 28, 2025 02:08
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 28, 2025
@pPrecel pPrecel marked this pull request as ready for review January 28, 2025 02:08
@pPrecel pPrecel requested a review from a team as a code owner January 28, 2025 02:08
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 28, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 28, 2025
@pPrecel pPrecel merged commit 80b4322 into kyma-project:main Jan 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichalKalke MichalKalke MichalKalke approved these changes

Assignees

@MichalKalke MichalKalke

Labels

area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/enhancement lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pPrecel @MichalKalke @kyma-bot