Skip to content

Refactor kymaconfig #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pPrecel merged 2 commits into from
Apr 3, 2025
Merged

Refactor kymaconfig #2446

pPrecel merged 2 commits into from
Apr 3, 2025

Conversation

@pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Apr 2, 2025

Description

Changes proposed in this pull request:

  • get rid of command dependency in KymaConfig contructor
  • move the flags pkg
  • make KubeClientConfig's fields private

Related issue(s)

@pPrecel pPrecel added area/cli Related to all activities around CLI kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 2, 2025
@pPrecel pPrecel requested a review from a team as a code owner April 2, 2025 23:48
@pPrecel pPrecel merged commit 269f09a into kyma-project:main Apr 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anoipm anoipm anoipm approved these changes

Assignees

No one assigned

Labels

area/cli Related to all activities around CLI kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pPrecel @anoipm