-
Notifications
You must be signed in to change notification settings - Fork 35
chore: Deprecate san-pinning flag #2965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Deprecate san-pinning flag #2965
Conversation
|
❌ Manifests created with 'make dry-run-control-plane' changed! Please make sure to check if changes are needed in related repositories like management-plane-charts, runtime-watcher, etc. |
c-pius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit surprised why parts of the san pinning functionality have been removed here already, but not entirely? #2961
do you know why we did that?
I think it was simply overlooked/forgotten by the author. Or it was intentionally left there, because we have a dedicated cleanup issue: #2440. @medmes any comment on that? |
|
The reason was to make the PRs smaller and iterative, and as the cleanup overlap with the ticket verifyFunc it was decided to not remove it at that stage. |
Description
See: #2966
This PR cleans up the related code, documentation and marks the
enable-domain-name-pinningflag as deprecated.Changes proposed in this pull request:
Related issue(s)
#2966