Skip to content

Conversation

@Tomasz-Smelcerz-SAP
Copy link
Member

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP commented Dec 31, 2025

Description
See: #2966
This PR cleans up the related code, documentation and marks the enable-domain-name-pinning flag as deprecated.

Changes proposed in this pull request:

  • Cleanup unused code
  • Cleanup the docs
  • Mark the flag as deprecated

Related issue(s)
#2966

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP requested review from a team as code owners December 31, 2025 07:05
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP changed the title Deprecate san-pinning flag chore: Deprecate san-pinning flag Dec 31, 2025
@github-actions
Copy link

Manifests created with 'make dry-run-control-plane' changed! Please make sure to check if changes are needed in related repositories like management-plane-charts, runtime-watcher, etc.

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP linked an issue Dec 31, 2025 that may be closed by this pull request
3 tasks
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit surprised why parts of the san pinning functionality have been removed here already, but not entirely? #2961

do you know why we did that?

@Tomasz-Smelcerz-SAP
Copy link
Member Author

Tomasz-Smelcerz-SAP commented Jan 7, 2026

I am a bit surprised why parts of the san pinning functionality have been removed here already, but not entirely? #2961

do you know why we did that?

I think it was simply overlooked/forgotten by the author. Or it was intentionally left there, because we have a dedicated cleanup issue: #2440. @medmes any comment on that?
I noticed these parts should be removed while reviewing the original PR. But then it became obvious that the flag is no longer necessary.
To avoid making the PR even bigger and adding additional concerns to it, I decided It was simpler and faster to approve the PR as it was, and collect these left-overs here.

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP enabled auto-merge (squash) January 7, 2026 07:13
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP linked an issue Jan 7, 2026 that may be closed by this pull request
3 tasks
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP merged commit bb5d8b3 into kyma-project:main Jan 7, 2026
58 checks passed
@medmes
Copy link
Member

medmes commented Jan 7, 2026

The reason was to make the PRs smaller and iterative, and as the cleanup overlap with the ticket verifyFunc it was decided to not remove it at that stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate the enable-domain-name-pinning flag [SKR Watch] Remove Verify func

4 participants