fix(gcr): fix syntax error in isFirstConnection function

[tcsenpai]

Fixed critical syntax error in the isFirstConnection method that was preventing TypeScript compilation. The if-else chain was malformed with orphaned braces and unreachable code.

Changes:

• Restructured the if-else chain to properly handle web2, ud, and web3 types
• Changed condition from if (type !== "web3") to if (type !== "web3" && type !== "ud")
• Removed orphaned closing braces and unreachable return statement
• Fixed indentation for the web3 (else) block

This resolves the following TypeScript errors:

• TS1068: Unexpected token
• TS1005: ',' expected
• TS1128: Declaration or statement expected

The UD identity integration will now function correctly with proper first-time connection detection for incentive points.

Summary by CodeRabbit

• Bug Fixes
  • Improved Unstoppable Domain identity handling by routing these identities through a dedicated processing path, separate from web2 and web3 identity flows.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The change modifies identity routing logic in GCRIdentityRoutines to handle Unstoppable Domain (UD) identities separately from the combined web2/web3 path. The isFirstConnection condition is updated to exclude UD types, ensuring they follow a dedicated code path. Clarifying comments and minor formatting adjustments accompany the logic change.

Changes

Cohort / File(s)	Change Summary
Identity Type Routing Logic src/libs/blockchain/gcr/gcr_routines/GCRIdentityRoutines.ts	Updates isFirstConnection condition to exclude "ud" type from web2/web3 unified branch (changes type !== "web3" to type !== "web3" && type !== "ud"); adds clarifying comment for web2 identity handling; minor formatting adjustments in query construction block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Straightforward conditional logic adjustment with single boolean operator addition
• Limited scope to routing logic within one function
• Low cognitive load for understanding intent and correctness

Poem

🐰 A rabbit hops with delight today—
UD identities now find their way!
No longer lost in the web2 thong,
Each type of identity fits just right all along. 🌐✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch claude/fix-ud-identities-011CUoJ58PE2u6TuoV6QTs8K

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 66298d4 and 8809fc5.

📒 Files selected for processing (1)

• src/libs/blockchain/gcr/gcr_routines/GCRIdentityRoutines.ts (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}