Added scriptable tokens support by tcsenpai · Pull Request #685 · kynesyslabs/node

tcsenpai · 2026-03-03T16:37:38Z

Delivers a “ship-it” token feature package by combining:

A reproducible multi-node devnet test harness (better_testing/) that validates token correctness and cross-node convergence.
A suite of complex token-script scenarios (branchy logic, dynamic policy updates, vesting/lockup via internal state, escrow-like state machine) to stress determinism and state handling.
Comprehensive token documentation (storage model, ACL, RPC read APIs, scripting execution model) with diagrams.
A consolidated test-results page with the exact RUN_IDs we executed + where to find artifacts.

Highlights

Complex scripting is now exercised beyond simple hooks:

deny/allow lists, quotas, fee bookkeeping
in-band admin policy updates through “command” transfers
vesting/lockup enforced via script state (admin-controlled unlocks)
escrow-style state machine with deterministic rejects and cross-node convergence
Documentation added to make tokens reviewable without spelunking the codebase.
Test runs are traceable via RUN_IDs and on-disk artifacts (better_testing/runs/<RUN_ID>/).

Summary by CodeRabbit

Release Notes

New Features
- Added Beadspace: interactive dashboard for viewing and managing issues with search, filtering, and analytics.
- Introduced Better Testing framework: comprehensive load generation and scenario testing for token operations, consensus, and ACL management.
- Enabled Token Scripting System: support for custom hooks, view functions, and complex policy execution on tokens.
- Added GitHub Pages automation: automatic deployment of Beadspace to GitHub Pages on repository updates.
Documentation
- Updated architectural and codebase documentation with streamlined guides.
- Added comprehensive testing and load generation documentation.
Configuration
- Updated project configuration and ignore patterns to support new testing infrastructure.

This reverts commit b8909f4.

qodo-code-review · 2026-03-04T14:59:04Z

Persistent review updated to latest commit ed9c402

src/libs/scripting/index.ts

src/libs/blockchain/gcr/handleGCR.ts

src/libs/consensus/v2/PoRBFT.ts

src/libs/blockchain/gcr/gcr_routines/GCRTokenRoutines.ts

github-actions · 2026-03-04T15:41:55Z

⚠️ MCP Memory Files Detected

This PR modifies .serena/ files. After merge, these changes will be automatically reverted to preserve branch-specific MCP memories.

Files that will be reverted:

.serena/memories/arch_hook_system.md
.serena/memories/arch_scripting_module_structure.md
.serena/memories/feature_scripting_custom_methods.md
.serena/memories/feature_scripting_system_complete.md
.serena/memories/feature_scripting_system_overview.md
.serena/memories/feature_scripting_system_phase2.md
.serena/memories/feature_scripting_validation_rules.md
.serena/memories/feature_scripting_view_functions.md
.serena/memories/pattern_scripting_types_sdk_vs_node.md
.serena/project.yml

github-actions · 2026-03-04T15:41:56Z

⚠️ Beads Issue Tracking Files Detected

This PR modifies .beads/ issue tracking files. After merge, these changes will be automatically reverted to preserve branch-specific issue tracking.

Files that will be reverted:

.beads/deletions.jsonl
.beads/issues.jsonl
.beads/metadata.json

tcsenpai · 2026-03-04T15:42:07Z

Resolved remaining review blockers with new commits on :\n\n- Unsafe script VM: disabled string codegen, blocked Date.now/Math.random, bounded compiled cache (src/libs/scripting/index.ts).\n- Non-deterministic timestamps/prevBlockHash: removed Date.now fallbacks and empty prevBlockHash in token contexts; ACL/script upgrade timestamps now use tx timestamp (src/libs/blockchain/gcr/gcr_routines/GCRTokenRoutines.ts).\n- Simulate rollback persistence: propagate simulate flag into rollback so validation cannot persist (src/libs/blockchain/gcr/handleGCR.ts).\n- Finalization atomicity: apply token edits + insert block in one DB transaction; Chain.insertBlock supports reuse of outer transaction (src/libs/consensus/v2/PoRBFT.ts, src/libs/blockchain/chain.ts).\n- Nonce/security/datasource: removed nonce bypass (assignNonce), added optional rate limiting (disabled unless SECURITY_RATE_LIMIT_ENABLED=true), and disabled TypeORM synchronize by default in production (TYPEORM_SYNCHRONIZE override) (src/libs/blockchain/routines/validateTransaction.ts, src/libs/network/securityModule.ts, src/model/datasource.ts).\n

tcsenpai · 2026-03-04T15:42:19Z

Resolved remaining review blockers with new commits on tokens:

Unsafe script VM: disabled string codegen, blocked Date.now/Math.random, bounded compiled cache (src/libs/scripting/index.ts).
Non-deterministic timestamps/prevBlockHash: removed Date.now fallbacks and empty prevBlockHash in token contexts; ACL/script upgrade timestamps now use tx timestamp (src/libs/blockchain/gcr/gcr_routines/GCRTokenRoutines.ts).
Simulate rollback persistence: propagate simulate flag into rollback so validation cannot persist (src/libs/blockchain/gcr/handleGCR.ts).
Finalization atomicity: apply token edits + insert block in one DB transaction; Chain.insertBlock supports reuse of outer transaction (src/libs/consensus/v2/PoRBFT.ts, src/libs/blockchain/chain.ts).
Nonce/security/datasource: removed nonce bypass (assignNonce), added optional rate limiting (disabled unless SECURITY_RATE_LIMIT_ENABLED=true), and disabled TypeORM synchronize by default in production (TYPEORM_SYNCHRONIZE override) (src/libs/blockchain/routines/validateTransaction.ts, src/libs/network/securityModule.ts, src/model/datasource.ts).

github-actions · 2026-03-04T16:06:11Z

⚠️ Beads Issue Tracking Files Detected

This PR modifies .beads/ issue tracking files. After merge, these changes will be automatically reverted to preserve branch-specific issue tracking.

Files that will be reverted:

.beads/deletions.jsonl
.beads/issues.jsonl
.beads/metadata.json

github-actions · 2026-03-04T16:06:14Z

⚠️ MCP Memory Files Detected

This PR modifies .serena/ files. After merge, these changes will be automatically reverted to preserve branch-specific MCP memories.

Files that will be reverted:

.serena/memories/arch_hook_system.md
.serena/memories/arch_scripting_module_structure.md
.serena/memories/feature_scripting_custom_methods.md
.serena/memories/feature_scripting_system_complete.md
.serena/memories/feature_scripting_system_overview.md
.serena/memories/feature_scripting_system_phase2.md
.serena/memories/feature_scripting_validation_rules.md
.serena/memories/feature_scripting_view_functions.md
.serena/memories/pattern_scripting_types_sdk_vs_node.md
.serena/project.yml

tcsenpai · 2026-03-04T16:06:35Z

Addressed the remaining CodeRabbit review summary note about by converting it to JSONL and removing the file (commit ).

tcsenpai · 2026-03-04T16:06:43Z

Addressed the remaining CodeRabbit review summary note about .beads/backup/backup_state.json by converting it to JSONL and removing the .json file (commit d34dda81).

tcsenpai · 2026-03-04T16:13:13Z

/agentic_review

qodo-code-review · 2026-03-04T16:13:25Z

Persistent review updated to latest commit d34dda8

.serena/memories/feature_scripting_system_complete.md

src/libs/network/manageNodeCall.ts

src/libs/blockchain/gcr/gcr_routines/GCRTokenRoutines.ts

src/libs/blockchain/routines/Sync.ts

github-actions · 2026-03-04T16:44:09Z

⚠️ Beads Issue Tracking Files Detected

This PR modifies .beads/ issue tracking files. After merge, these changes will be automatically reverted to preserve branch-specific issue tracking.

Files that will be reverted:

.beads/deletions.jsonl
.beads/issues.jsonl
.beads/metadata.json

github-actions · 2026-03-04T16:44:15Z

⚠️ MCP Memory Files Detected

This PR modifies .serena/ files. After merge, these changes will be automatically reverted to preserve branch-specific MCP memories.

Files that will be reverted:

.serena/memories/arch_hook_system.md
.serena/memories/arch_scripting_module_structure.md
.serena/memories/feature_scripting_custom_methods.md
.serena/memories/feature_scripting_system_complete.md
.serena/memories/feature_scripting_system_overview.md
.serena/memories/feature_scripting_system_phase2.md
.serena/memories/feature_scripting_validation_rules.md
.serena/memories/feature_scripting_view_functions.md
.serena/memories/pattern_scripting_types_sdk_vs_node.md
.serena/project.yml

tcsenpai · 2026-03-04T16:45:55Z

New Qodo review round addressed on tokens:

Phase checklist in .serena doc: removed the in-repo phase/progress checklist; doc is now informational only (commit 68ce2be5).
Uninitialized datasource access in token nodeCalls: replaced direct dataSource.getRepository(...) with await Datasource.getInstance()-backed repositories (commit d24ded16).
Token caller spoofing: reject token edits when edit.account != tx.content.from (commit b740e965).
Sync script context drift: apply GCR/token edits before Chain.insertBlock() during sync/batch sync so scripts see correct prevBlockHash; also ensure tx.blockNumber is set (commit 62065733).

github-actions · 2026-03-04T16:46:03Z

⚠️ Beads Issue Tracking Files Detected

This PR modifies .beads/ issue tracking files. After merge, these changes will be automatically reverted to preserve branch-specific issue tracking.

Files that will be reverted:

.beads/deletions.jsonl
.beads/issues.jsonl
.beads/metadata.json

github-actions · 2026-03-04T16:46:14Z

⚠️ MCP Memory Files Detected

This PR modifies .serena/ files. After merge, these changes will be automatically reverted to preserve branch-specific MCP memories.

Files that will be reverted:

.serena/memories/arch_hook_system.md
.serena/memories/arch_scripting_module_structure.md
.serena/memories/feature_scripting_custom_methods.md
.serena/memories/feature_scripting_system_complete.md
.serena/memories/feature_scripting_system_overview.md
.serena/memories/feature_scripting_system_phase2.md
.serena/memories/feature_scripting_validation_rules.md
.serena/memories/feature_scripting_view_functions.md
.serena/memories/pattern_scripting_types_sdk_vs_node.md
.serena/project.yml

sonarqubecloud · 2026-03-04T16:47:57Z

Quality Gate failed

Failed conditions
45 Security Hotspots
9.1% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

tcsenpai added 30 commits February 22, 2026 16:57

docs: map existing codebase

67d37a2

docs: add repository semantic map

a454f37

chore: refresh semantic map for baseline ref

a3d0626

chore: add embeddings generator for semantic map

fcc8d5e

chore: add local embeddings for semantic index

1bf0da0

docs: point agents to repository semantic map

5173ed1

chore: add canonical check command

f1ade44

fix(devnet): set genesis from_ed25519_address

38609ff

fix(devnet): avoid bootstrap race in getGenesisDataHash

b8909f4

Revert "fix(devnet): avoid bootstrap race in getGenesisDataHash"

ee8ae14

This reverts commit b8909f4.

fix(devnet): make getGenesisDataHash startup-safe

02eba32

perf(loadgen): add transfer ramp, quiet mode, and hygiene

81b7018

perf(loadgen): write run artifacts and per-second timeseries

16d41c6

perf(loadgen): persist run artifacts (gitignored)

473e9f5

memories

69e9ace

cleanup

abd9111

cleanup 2

f173f9d

fix: prevent token balance divergence under load

44dcc5d

fix: make token holder pointers and sync tx fetching reliable

ac0ab02

fix: serialize token mint/burn updates

af34af1

chore: ignore local beads runtime dirs

2dd36c4

test(loadgen): add token ACL smoke scenario

754575a

fix: IM WS loadgen + signaling server tx signing

0a8c249

test: token consensus consistency scenario

c12e8c9

test: token read/query coverage scenario

fd29c88

test(tokens): add token ACL matrix scenario

9323fae

test(tokens): add token edge-cases scenario

7abb7fa

chore(better_testing): add runner scripts and perf baseline

0db1aeb

test(tokens): add canBurn ACL matrix scenario

e667241

test(tokens): add pause/unpause ACL matrix scenario

452dad2

qodo-code-review bot reviewed Mar 4, 2026

View reviewed changes

src/libs/scripting/index.ts Show resolved Hide resolved

src/libs/blockchain/gcr/handleGCR.ts Show resolved Hide resolved

src/libs/consensus/v2/PoRBFT.ts Show resolved Hide resolved

src/libs/blockchain/gcr/gcr_routines/GCRTokenRoutines.ts Show resolved Hide resolved

tcsenpai added 5 commits March 4, 2026 16:19

fix(scripting): harden token script VM

53fd1a6

fix(tokens): make hook contexts deterministic

5300856

fix(consensus): keep simulate rollbacks non-persisting

edab550

fix(consensus): atomically finalize blocks with token edits

714aee5

fix(security): restore nonce checks and add rate limiting

2971107

chore(beads): store backup state as jsonl

d34dda8

qodo-code-review bot reviewed Mar 4, 2026

View reviewed changes

tcsenpai added 4 commits March 4, 2026 17:40

fix(tokens): prevent caller spoofing in token edits

b740e96

fix(rpc): init TypeORM for token nodeCalls

d24ded1

chore(docs): remove in-repo phase checklist

68ce2be

fix(sync): apply token edits before inserting block

6206573

chore(br): update issues

9cde2f5

Conversation

tcsenpai commented Mar 3, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Highlights

Summary by CodeRabbit

Release Notes

Uh oh!

qodo-code-review bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

tcsenpai commented Mar 4, 2026

Uh oh!

tcsenpai commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

tcsenpai commented Mar 4, 2026

Uh oh!

tcsenpai commented Mar 4, 2026

Uh oh!

tcsenpai commented Mar 4, 2026

Uh oh!

qodo-code-review bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

tcsenpai commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

sonarqubecloud bot commented Mar 4, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tcsenpai commented Mar 3, 2026 •

edited by coderabbitai bot

Loading

qodo-code-review bot commented Mar 4, 2026 •

edited

Loading

qodo-code-review bot commented Mar 4, 2026 •

edited

Loading