Open
Conversation
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an in-app configuration file editor (YAML/JSON/TOML) and wires it into organization/project/repository settings so users can navigate to dedicated “Configuration Files” pages and edit scanner configs in the UI.
Changes:
- Introduce a reusable
CodeEditor(CodeMirror) with YAML/JSON/TOML linting and theme support. - Add
ConfigFileEditorto fetch/edit config files via API and provide a tabbed UI for multiple tools. - Add navigation sections + new settings sub-pages at org/project/repo scope; update dependencies to support TOML parsing and CodeMirror themes.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/common/ConfigFileEditor.tsx | New client component to view/edit config files via SWR + PUT, with tabs and edit mode |
| src/components/common/CodeEditor.tsx | New client CodeMirror wrapper with language modes + linters and theme switching |
| src/app/(loading-group)/[organizationSlug]/settings/page.tsx | Adds a “Configuration Files” section linking to org config editor page |
| src/app/(loading-group)/[organizationSlug]/settings/config/page.tsx | New org-level config editor page hosting ConfigFileEditor |
| src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/settings/page.tsx | Adds a “Configuration Files” section linking to project config editor page |
| src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/settings/config/page.tsx | New project-level config editor page hosting ConfigFileEditor |
| src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/assets/[assetSlug]/settings/page.tsx | Adds a “Configuration Files” section linking to repo config editor page |
| src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/assets/[assetSlug]/settings/config/page.tsx | New repo-level config editor page hosting ConfigFileEditor |
| package.json | Adds TOML parser, CodeMirror theme packages, and js-yaml types |
| package-lock.json | Lockfile updates for the added dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/app/(loading-group)/[organizationSlug]/settings/config/page.tsx
Outdated
Show resolved
Hide resolved
src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/settings/config/page.tsx
Outdated
Show resolved
Hide resolved
...group)/[organizationSlug]/projects/[projectSlug]/assets/[assetSlug]/settings/config/page.tsx
Outdated
Show resolved
Hide resolved
src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/settings/page.tsx
Outdated
Show resolved
Hide resolved
...oading-group)/[organizationSlug]/projects/[projectSlug]/assets/[assetSlug]/settings/page.tsx
Outdated
Show resolved
Hide resolved
…ents Signed-off-by: rafi <refaei.shikho@hotmail.com>
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Member
|
@refoo0 could you implement dark mode support, highlight the settings page menu when on the config file page, add breadcrumb to settings page (we need breadcrumbs on all pages), IaC (checkov) is missing as well https://www.checkov.io/ |
Signed-off-by: rafi <refaei.shikho@hotmail.com>
…ton state logic Signed-off-by: rafi <refaei.shikho@hotmail.com>
Signed-off-by: rafi <refaei.shikho@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.