Open
Conversation
Owner
|
Thank you for your interest in flatten! I hope you find it useful. Here're my thoughts on this PR: The readme suggests calling flatten this way: If we were to merge your changes, it seems we'd by saying the following is preferable: Isn't the first way simpler? What's the benefit of providing a longer way to do the same thing? Best, Lex |
close parens
Author
|
But it's not the same thing. I'd like to be able to specify that it smash arrays and add a separator.
[7] pry(main)> h.smash
=> {"year"=>1925, "color"=>"red", "images"=>["url1", "url2"]}[8] pry(main)> h.smash(smash_array: true, separator: '/')
=> {"build/year"=>1925, "build/color"=>"red", "images/0"=>"url1", "images/1"=>"url2"}Basically, I want the same output as this [9] pry(main)> Flatten.smash(h, smash_array: true, separator: '/')
=> {"build/year"=>1925, "build/color"=>"red", "images/0"=>"url1", "images/1"=>"url2"}It's not terrible to call the class method, but it would be convenient to be able to call it from an instantiated hash object. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it would be nice to be able to call
hash.smash(smash_array: true)instead of having to doFlatten.smash(hash, smash_array: true)