Conversation
of the loops
the sparsification tests
max-veit
left a comment
There was a problem hiding this comment.
Part the Second, in which the C++ code is reviewed.
Ok, I can follow what's going on for the most part, although some features need better documentation (see comments). It seems that the sparsification has the nice side effect of reducing the nesting depth in many loops, which definitely aids understanding. New test structure looks good and is much easier to understand.
|
Um, how about changing the Python formatter in a different branch and PR? There's enough changes mixed up into this one already. |
|
Sure that's how it should be done. |
|
Then why does the latest commit add |
|
right got added by mistake I guess. |
(Update to version of CURFilter and FPSFilter from PR #265)
This PR allow for the sparsification of the powerspectrum.
Changes on the C++ side:
Changes on the python side: