feat: add connection pooling infrastructure for future features#1
Merged
feat: add connection pooling infrastructure for future features#1
Conversation
- Implement ConnectionPool module as placeholder for future use - Add analysis showing pooling provides no benefit for current usage - Document design decision in ARCHITECTURE.md - Include unit tests for pool API surface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a connection pooling module as infrastructure for future features. After thorough analysis, connection pooling provides no benefit for bssh's current one-shot execution model, but the infrastructure is added for future interactive features.
Changes
ConnectionPoolmodule (src/ssh/pool.rs) as placeholder implementationsrc/ssh/mod.rsARCHITECTURE.mdAnalysis Results
Connection pooling is not beneficial for current usage because:
Clienttype doesn't support cloning or connection reuseWhen Pooling Would Help
The infrastructure will be useful when implementing:
Implementation Details
Testing
Recommendation
Focus on more impactful optimizations like: