Conversation
…ures The password fallback mechanism now correctly triggers for all SSH agent related authentication failures, not just SSH key authentication errors. Previously, only SshError::KeyAuthFailed was matched for password fallback, but SSH agent authentication can fail with different error types: - AgentAuthenticationFailed (most common) - AgentNoIdentities (agent has no keys) - AgentConnectionFailed (agent connection error) - AgentRequestIdentitiesFailed (identity request failed) This change extends the pattern matching to include all these error types, allowing password fallback to work correctly when SSH agent authentication fails, matching OpenSSH behavior. Fixes #84
inureyes
added
type:bug
- Add is_auth_error_for_password_fallback() helper function for testability - Add unit tests for all SSH authentication error types that should trigger password fallback (KeyAuthFailed, AgentAuthenticationFailed, AgentNoIdentities, AgentConnectionFailed, AgentRequestIdentitiesFailed) - Add negative tests to verify non-auth errors don't trigger fallback - Add integration test file (tests/password_fallback_test.rs) - Export connection module publicly for test access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
establish_connectionfunction to include SSH agent related authentication errorsSshError::KeyAuthFailed(existing)SshError::AgentAuthenticationFailed(new)SshError::AgentNoIdentities(new)SshError::AgentConnectionFailed(new)SshError::AgentRequestIdentitiesFailed(new)Test plan
cargo checkpassescargo clippy -- -D warningspassescargo testpassesFixes #84