feat: Add pre-commit hooks for code formatting, linting#129
Merged
jopemachine merged 3 commits intolablup:mainfrom Sep 29, 2024
Merged
feat: Add pre-commit hooks for code formatting, linting#129jopemachine merged 3 commits intolablup:mainfrom
jopemachine merged 3 commits intolablup:mainfrom
Conversation
Contributor
Author
|
Note: After this PR is merged, the contribution guide should be updated to include the new pre-commit hooks. Contributors will need to install and configure the pre-commit hooks locally to ensure proper formatting and linting before making any commits. |
Member
|
Does code formatting and linting checks also apply to the crate in the binding/python directory, in addition to the root directory? |
Member
|
Ref: Prerequisites:
|
3a0a83f to
a59e00e
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces pre-commit hooks to ensure consistent code quality and formatting across the project. The following hooks were added:
Rust Hooks:
cargo fmt: Automatically formats Rust code according to the standard style.cargo clippy: Lints Rust code to detect potential issues and improve code quality.General Code Quality Hooks:
trailing-whitespace: Removes unnecessary trailing whitespace from files.end-of-file-fixer: Ensures that files end with a newline.check-yaml: Validates YAML file syntax.check-added-large-files: Prevents large files from being accidentally committed to the repository.Python Hooks:
ruff: Lints Python code and automatically fixes style issues.