fix redirect middleware panicing on short host name (fix #1811) #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1813 +/- ##
==========================================
+ Coverage 89.49% 89.71% +0.21%
==========================================
Files 32 32
Lines 2685 2684 -1
==========================================
+ Hits 2403 2408 +5
+ Misses 181 178 -3
+ Partials 101 98 -3
Continue to review full report at Codecov.
|
lammel
approved these changes
Mar 17, 2021
Contributor
lammel
left a comment
lammel
left a comment
There was a problem hiding this comment.
Nice catch.
Good to see more table driven tests too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix redirect middleware panicing on short host name (fix #1811)