[suggestion] Add helper interface for ProxyBalancer interface #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldas
requested changes
Oct 25, 2022
aldas
requested changes
Oct 26, 2022
Contributor
aldas
left a comment
aldas
left a comment
There was a problem hiding this comment.
Could you add additional test for returning error and not proxing the request, as it was the reason for creating this PR.
Codecov ReportBase: 92.35% // Head: 92.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2316 +/- ##
==========================================
+ Coverage 92.35% 92.37% +0.01%
==========================================
Files 37 37
Lines 4436 4446 +10
==========================================
+ Hits 4097 4107 +10
Misses 247 247
Partials 92 92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aldas
requested changes
Oct 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is discussed in this issue