Skip to content

Various improvements in AprilTag support#1941

Merged
fspindle merged 3 commits intolagadic:masterfrom
fspindle:fix_apriltag_3_4_5_debian_compat
Apr 13, 2026
Merged

Various improvements in AprilTag support#1941
fspindle merged 3 commits intolagadic:masterfrom
fspindle:fix_apriltag_3_4_5_debian_compat

Conversation

@fspindle
Copy link
Copy Markdown
Contributor

Remove useless code that breaks cmake configuration:

CMake Error at /usr/lib/x86_64-linux-gnu/apriltag/cmake/apriltagTargets.cmake:42 (message):
  Some (but not all) targets in this export set were already defined.

  Targets Defined: apriltag::apriltag

  Targets not yet defined: apriltag::apriltag-utils

Call Stack (most recent call first):
  /usr/lib/x86_64-linux-gnu/apriltag/cmake/apriltagConfig.cmake:42 (include)
  cmake/VISP3rdParty.cmake:36 (find_package)
  CMakeLists.txt:1127 (include)
…uco folder

See PR AprilRobotics/apriltag#436
Update also the README.VISP file that ecplains changes introduced in apriltag 3rdparty
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.68%. Comparing base (10ba152) to head (e719c33).
⚠️ Report is 39 commits behind head on master.

Files with missing lines Patch % Lines
modules/detection/src/tag/vpDetectorAprilTag.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
- Coverage   48.68%   48.68%   -0.01%     
==========================================
  Files         532      532              
  Lines       69311    69311              
  Branches    32414    32414              
==========================================
- Hits        33746    33743       -3     
+ Misses      24974    24969       -5     
- Partials    10591    10599       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fspindle fspindle merged commit 8033ecf into lagadic:master Apr 13, 2026
86 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant