Skip to content

Fix Error on non-existent target in get_target_property for 3rd party… #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fspindle merged 1 commit into from
Aug 22, 2018
Merged

Fix Error on non-existent target in get_target_property for 3rd party… #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions modules/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,6 @@ if(USE_OPENCV)
# ReleaseWithDebugInfo was requested to detect libopencv-devel under Fedora 20
# RelWithDebugInfo was requested to detect ros-hydro-opencv2 2.4.9 under Ubuntu 12.04 LTS with ROS hydro
set(config_ "NONE" "RELEASE" "DEBUG" "RELEASEWITHDEBINFO" "RELWITHDEBINFO")
if(POLICY CMP0045)
# Fix Error on non-existent target in get_target_property for 3rd party location extraction
cmake_policy(PUSH)
cmake_policy(SET CMP0045 NEW)
endif()

foreach(component_ ${OpenCV_LIB_COMPONENTS})
foreach(imp_config_ ${config_})
Expand All @@ -94,7 +89,7 @@ if(USE_OPENCV)
list(APPEND opt_libs "${component_property_${imp_config_}_}")
endif()

if(component_property_3rdparty_${imp_config_}_)
if(EXISTS "${component_property_3rdparty_${imp_config_}_}")
foreach(3rdparty_ ${component_property_3rdparty_${imp_config_}_})
#message("3rdparty_ ${3rdparty_}")
list(FIND OpenCV_LIB_COMPONENTS ${3rdparty_} 3rdparty_is_opencv_component_)
Expand Down Expand Up @@ -132,10 +127,6 @@ if(USE_OPENCV)
endforeach()
endforeach()

if(POLICY CMP0045)
# Fix Error on non-existent target in get_target_property for 3rd party location extraction
cmake_policy(POP)
endif()
elseif(APPLE_FRAMEWORK)
# Add opencv framework
list(APPEND opt_libs ${OpenCV_LIBRARIES}) # see FindMyOpenCV.cmake
Expand Down