-
Notifications
You must be signed in to change notification settings - Fork 11
Additional docker-compose file just for Lando to fix the additional_contexts issue #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ing with the lando only file
|
Oops, just realized I commented on the issue last time. This PR still doesn't work for me unfortunately. I deleted the local docker images (that were built from this example in the past) and |
|
You are right. If after you do a lando rebuild -y, you do a lando start, the application eventually does start (for me) but its not building correctly. I have been fidgeting a lot with it but can't get it to work. Stuck on this one. |
|
if you switch it up so that the additional_contexts is removed from the docker-compose.yml, and instead put them into a docker-compose.override.yml as below - does that work? this should allow lando and lagoon to use the old format, but docker compose & pygmy to autoread the override file for compatibility |
Pygmy users will run docker compose with the base docker-compose.yml, no change, everything works with additional_contexts.
For Lando users, it will load both docker-compose.yml and docker-compose.lando.yml.
The override replaces the build blocks for php and nginx.
This strips the additional_contexts that break Lando, but keeps the CLI_IMAGE arg wiring.