Added PTZ support, improved discovery, and refactored code and coroutines#1
Merged
lamba92 merged 1 commit intolamba92:masterfrom May 6, 2020
Merged
Added PTZ support, improved discovery, and refactored code and coroutines#1lamba92 merged 1 commit intolamba92:masterfrom
lamba92 merged 1 commit intolamba92:masterfrom
Conversation
Owner
|
Thank you for the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have had problems with discovery (was not able to detect my camera) and coroutines (exception was not thrown in case of a failed request).
I also added PTZ support and refactored the code.
@lamba92 If you have a moment please have a look at this PR, and thanks for your efforts for adding Kotlin support!