Skip to content

Conversation

@emyfops
Copy link
Collaborator

@emyfops emyfops commented Jul 8, 2024

This pull request modifies the mod's file dependency to be in range of the major version of minecraft since modloaders assure compatibility for all major versions

However, thedarkcolour/KotlinForForge could cause issues due to inconsistent version releasing and compatibility

@github-actions github-actions bot added 1.20 triage Requires labelling or review labels Jul 8, 2024
@emyfops emyfops removed the triage Requires labelling or review label Jul 8, 2024
@emyfops
Copy link
Collaborator Author

emyfops commented Jul 8, 2024

We could drop the use of the library for forge-like and simply transform the entrypoint objects into classes so the jvm doesn't panic when it sees a private constructor

@github-actions
Copy link

github-actions bot commented Jul 8, 2024

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@emyfops
Copy link
Collaborator Author

emyfops commented Jul 10, 2024

After some tests and investigations kff will not cause us any issues unlike Baritone which has not only a broken maven publish but also only one release per major mc version

@emyfops emyfops added this to the Open Beta milestone Jul 10, 2024
@emyfops
Copy link
Collaborator Author

emyfops commented Jul 10, 2024

Tests

For some reasons Fabric simply don't boot up, nothing related to the mod but I know it works just fine
I was able to launch the mod using NeoForge on any version but #34 prevented me to actually play

@emyfops emyfops merged commit 1052a24 into master Jul 10, 2024
@emyfops emyfops deleted the all-modloaders-support-major-version branch July 10, 2024 21:02
emyfops added a commit that referenced this pull request Jul 10, 2024
commit 1052a24
Author: Edouard127 <46357922+Edouard127@users.noreply.github.com>
Date:   Wed Jul 10 17:02:29 2024 -0400

    [1.20.x] Support all major versions (#33)

    This pull request modifies the mod's file dependency to be in range of
    the major version of minecraft since modloaders assure compatibility for
    all major versions
@emyfops emyfops changed the title [1.20.x] Support all major versions [1.20.x] [All] Support major versions Oct 30, 2024
@github-actions github-actions bot added the triage Requires labelling or review label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Requires labelling or review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants