Adopt laminas-coding-standard v2 and bump minimum version of dependencies #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Drops legacy dependencies to simplify QA story and reduce complexity (specifically, removes need to have versioned and aliased versions of the EntityExtractor): - Drop laminas-eventmanager v2 releases - Drop laminas-hydrator v2 releases - Drop laminas-mvc v2 releases - Drop laminas-stdlib v2 releases Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
changed the title
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had previously updated to it in the PHP 8.0 support patch (#24), but it wasn't actually running correctly due to issues having to do with our class aliasing to support different versions of laminas-hydrator.
This patch applies it fully, and fixes CS issues raised by the new ruleset.
Additionally, the patch drops legacy versions of the following packages, to simplify maintenance: