Skip to content

remove NOT NULL for client_secret #9

@weierophinney

Description

@weierophinney

In
oauth_clients -> client_secret character varying(80) NOT NULL,

And then in PDO:
public function isPublicClient($client_id) { $stmt = $this->db->prepare(sprintf('SELECT * from %s where client_id = :client_id', $this->config['client_table'])); $stmt->execute(compact('client_id')); if (!$result = $stmt->fetch(\PDO::FETCH_ASSOC)) { return false; } return empty($result['client_secret']); }

How can $result['client_secret'] be empty?
IMHO the "NOT NULL" is wrong as it is needed I.E. for 'allow_implicit' => true example.


Originally posted by @goalain at zfcampus/zf-oauth2#156

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions