fix(monitors): aggregate service status across active monitors#3
Open
mark-mckee wants to merge 1 commit into
Open
fix(monitors): aggregate service status across active monitors#3mark-mckee wants to merge 1 commit into
mark-mckee wants to merge 1 commit into
Conversation
When multiple monitors are attached to the same Service, _apply_service_status currently overwrites whatever the last check-in produced. A recovery in one monitor masks an active outage on another. This adds _compute_service_status which computes the worst (per _STATUS_PRIORITY) across all active monitors on the service, treating the just-completed monitor's candidate as that monitor's contribution (its last_status may not be persisted yet). Service status is updated only when the aggregated state actually changes, so single-monitor services are unaffected. Maintenance mode and admin/API overrides also untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple monitors are attached to the same Service, _apply_service_status currently overwrites whatever the last check-in produced. A recovery in one monitor masks an active outage on another.
This adds _compute_service_status which computes the worst (per _STATUS_PRIORITY) across all active monitors on the service, treating the just-completed monitor's candidate as that monitor's contribution (its last_status may not be persisted yet).
Service status is updated only when the aggregated state actually changes, so single-monitor services are unaffected. Maintenance mode and admin/API overrides also untouched.