fix(java): keep async query responses as bytes#321
Merged
jackye1995 merged 5 commits intomainfrom Mar 17, 2026
Merged
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Xuanwo
changed the title
Xuanwo
force-pushed
the
xuanwo/fix-java-async-querytable-bytes
branch
from
ffc4a78 to
0ca4319
Compare
Xuanwo
force-pushed
the
xuanwo/fix-java-async-querytable-bytes
branch
from
0ca4319 to
a6c39c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates only the Java async client codegen path to use a vendored native template and keep binary query responses as
byte[]. The async generator now explicitly usesopenapi-generator-cli 7.20.0, while the repository default remains7.12.0so the existing Python, Rust, sync Java client, and Spring server codegen outputs stay unchanged.The previous async client path could either parse Arrow IPC bytes as JSON (
ARROW1) or generateFilehandling that mismatched our--type-mappings file=byte[]configuration. I regenerated the async client, ranmake checkinjava/with JDK 17, and ran top-levelmake gento confirm the spec codegen check stays clean.