Skip to content

Refactor mask related components to distinguish row ID and row address #5326

@yanghua

Description

@yanghua

There are some structs(RowIdSelection, RowIdTreeMap, RowIdMask) in mask.rs that have two kinds of semantics for row address and (stable) row id.

It would be better to split the responsibility of the struct for distinguishing row ID(stable) and row address.

  • for row address:

    • RowIdTreeMap -> RowAddrMap(BTreeMap<u32, RowAddrSelection>)
    • RowIdSelectionRowAddrSelection(Full | Partial(RoaringBitmap))
    • SearchResult(scalar.rs) → RowAddrSearchResult (Exact(RowAddrMap) | AtMost(RowAddrMap)|...)
    • RowIdMaskRowAddrMask
  • for (stable) row id:

    • add rowid::RowIdSet (RoaringTreemap,64-bit set)
    • add rowid::RowIdMask
    • add RowIdResolver(row_id -> row_addr)
  • for both:

    • add RowSetOps for RowIdSet and RowAddrMap

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions