There are some structs(RowIdSelection, RowIdTreeMap, RowIdMask) in mask.rs that have two kinds of semantics for row address and (stable) row id.
It would be better to split the responsibility of the struct for distinguishing row ID(stable) and row address.
-
for row address:
RowIdTreeMap -> RowAddrMap(BTreeMap<u32, RowAddrSelection>)
RowIdSelection → RowAddrSelection(Full | Partial(RoaringBitmap))
SearchResult(scalar.rs) → RowAddrSearchResult (Exact(RowAddrMap) | AtMost(RowAddrMap)|...)
RowIdMask → RowAddrMask
-
for (stable) row id:
- add rowid::
RowIdSet (RoaringTreemap,64-bit set)
- add rowid::
RowIdMask
- add
RowIdResolver(row_id -> row_addr)
-
for both:
- add
RowSetOps for RowIdSet and RowAddrMap
There are some structs(
RowIdSelection,RowIdTreeMap,RowIdMask) inmask.rsthat have two kinds of semantics for row address and (stable) row id.It would be better to split the responsibility of the struct for distinguishing row ID(stable) and row address.
for row address:
RowIdTreeMap->RowAddrMap(BTreeMap<u32, RowAddrSelection>)RowIdSelection→RowAddrSelection(Full | Partial(RoaringBitmap))SearchResult(scalar.rs) →RowAddrSearchResult(Exact(RowAddrMap) | AtMost(RowAddrMap)|...)RowIdMask→RowAddrMaskfor (stable) row id:
RowIdSet(RoaringTreemap,64-bit set)RowIdMaskRowIdResolver(row_id -> row_addr)for both:
RowSetOpsforRowIdSetandRowAddrMap