Skip to content

Conversation

@vrongmeal
Copy link

@vrongmeal vrongmeal commented Dec 11, 2023

Known test failure:

Due to a change in DF where statistics are pulled even when not requested in IndentVisitor, the test dataset::scanner::test::test_secondary_index_scans fails since there's an error pulling statistics. The error corresponds to not being able to create a scalar from FixedSizeList (which should not be expected since a corresponding scalar exists).

The error:

This feature is not implemented: Can't create a scalar from data_type "FixedSizeList(Field { name: "item", data_type: Float32, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }, 32)"

Problematic DF Code:

https://github.com/apache/arrow-datafusion/blob/93b21bdcd3d465ed78b610b54edf1418a47fc497/datafusion/physical-plan/src/display.rs#L263-L266

Fixes: #1694

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@github-actions
Copy link
Contributor

ACTION NEEDED

Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@vrongmeal vrongmeal changed the title chore: Update arrow (to 48.0) and datafusion (to 33.0) chore: update arrow (to 48.0) and datafusion (to 33.0) Dec 11, 2023
@wjones127
Copy link
Contributor

@vrongmeal Unfortunately, we might not be able to upgrade until the next version of DataFusion. We added the FSL implementation in apache/datafusion/pull/8225, which should be available in DF 34.

@vrongmeal
Copy link
Author

@vrongmeal Unfortunately, we might not be able to upgrade until the next version of DataFusion. We added the FSL implementation in apache/datafusion#8225, which should be available in DF 34.

That makes sense! Thanks! I'll close this PR for now.

@vrongmeal vrongmeal closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Arrow and Datafusion

2 participants