Skip to content

feat: support build IVF_FLAT with binary vectors#2434

Closed
BubbleCal wants to merge 7 commits intolance-format:mainfrom
BubbleCal:ivf-with-hamming
Closed

feat: support build IVF_FLAT with binary vectors#2434
BubbleCal wants to merge 7 commits intolance-format:mainfrom
BubbleCal:ivf-with-hamming

Conversation

@BubbleCal
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 68.94273% with 282 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (6b95cd5) to head (f81f267).

Files Patch % Lines
rust/lance/src/index/vector/ivf/v2.rs 67.59% 110 Missing and 18 partials ⚠️
rust/lance-index/src/vector/v3/storage.rs 56.71% 19 Missing and 10 partials ⚠️
rust/lance/src/index/vector/ivf.rs 67.64% 18 Missing and 4 partials ⚠️
rust/lance-linalg/src/kmeans.rs 80.20% 19 Missing ⚠️
rust/lance-index/src/vector/kmeans.rs 57.50% 15 Missing and 2 partials ⚠️
rust/lance/src/index/vector/builder.rs 66.66% 6 Missing and 7 partials ⚠️
rust/lance/src/index/vector/fixture_test.rs 0.00% 6 Missing ⚠️
rust/lance-linalg/src/distance/cosine.rs 0.00% 5 Missing ⚠️
rust/lance-linalg/src/distance/dot.rs 0.00% 5 Missing ⚠️
rust/lance/src/index/vector/hnsw.rs 0.00% 5 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2434      +/-   ##
==========================================
- Coverage   79.78%   79.77%   -0.01%     
==========================================
  Files         205      205              
  Lines       56547    57230     +683     
  Branches    56547    57230     +683     
==========================================
+ Hits        45114    45657     +543     
- Misses       8753     8863     +110     
- Partials     2680     2710      +30     
Flag Coverage Δ
unittests 79.77% <68.94%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal force-pushed the ivf-with-hamming branch 6 times, most recently from 53ee432 to 9c9afe6 Compare June 6, 2024 14:19
@github-actions github-actions Bot added the python label Jun 6, 2024
@BubbleCal BubbleCal force-pushed the ivf-with-hamming branch 2 times, most recently from daa6923 to f81f267 Compare June 6, 2024 15:40
BubbleCal added 5 commits June 7, 2024 00:29
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal closed this Dec 5, 2024
@BubbleCal
Copy link
Copy Markdown
Contributor Author

move to #3198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants