Skip to content

chore: add expect_stat, expect_single_stat in GetStat trait#3126

Merged
broccoliSpicy merged 4 commits intolance-format:mainfrom
broccoliSpicy:expect-stat
Nov 26, 2024
Merged

chore: add expect_stat, expect_single_stat in GetStat trait#3126
broccoliSpicy merged 4 commits intolance-format:mainfrom
broccoliSpicy:expect-stat

Conversation

@broccoliSpicy
Copy link
Copy Markdown
Contributor

This PR tries to add helper function expect_stat and expect_single_stat to make DataBlock statistics easier to use.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 94.20290% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.05%. Comparing base (e6c2343) to head (c1ecd63).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-encoding/src/statistics.rs 94.08% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3126      +/-   ##
==========================================
+ Coverage   78.00%   78.05%   +0.04%     
==========================================
  Files         243      243              
  Lines       82889    82661     -228     
  Branches    82889    82661     -228     
==========================================
- Hits        64660    64517     -143     
+ Misses      15005    14936      -69     
+ Partials     3224     3208      -16     
Flag Coverage Δ
unittests 78.05% <94.20%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this one slipped under my radar. Sorry for the slow review and thanks for the cleanup!

@broccoliSpicy broccoliSpicy merged commit dc9afbb into lance-format:main Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants