chore: add expect_stat, expect_single_stat in GetStat trait#3126
Merged
broccoliSpicy merged 4 commits intolance-format:mainfrom Nov 26, 2024
Merged
chore: add expect_stat, expect_single_stat in GetStat trait#3126broccoliSpicy merged 4 commits intolance-format:mainfrom
broccoliSpicy merged 4 commits intolance-format:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3126 +/- ##
==========================================
+ Coverage 78.00% 78.05% +0.04%
==========================================
Files 243 243
Lines 82889 82661 -228
Branches 82889 82661 -228
==========================================
- Hits 64660 64517 -143
+ Misses 15005 14936 -69
+ Partials 3224 3208 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
westonpace
approved these changes
Nov 25, 2024
Member
westonpace
left a comment
There was a problem hiding this comment.
Oops, this one slipped under my radar. Sorry for the slow review and thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to add helper function
expect_statandexpect_single_statto make DataBlock statistics easier to use.