feat: support write multi fragments or empty fragment in one spark task#3183
Merged
LuQQiu merged 6 commits intolance-format:mainfrom Dec 2, 2024
Merged
feat: support write multi fragments or empty fragment in one spark task#3183LuQQiu merged 6 commits intolance-format:mainfrom
LuQQiu merged 6 commits intolance-format:mainfrom
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
277b6a0 to
a3eb987
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3183 +/- ##
==========================================
+ Coverage 78.06% 78.72% +0.66%
==========================================
Files 243 243
Lines 82661 82793 +132
Branches 82661 82793 +132
==========================================
+ Hits 64529 65180 +651
+ Misses 14932 14833 -99
+ Partials 3200 2780 -420
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LuQQiu
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
FileFragment::createonly support create one file fragment and in spark connector will cause these two issues:So I remove the assigned fragment id and add a new method named
FileFragment::create_fragmentsto generate empty or multi fragments.