ci(java): introduce spotless-maven-plugin#3193
Merged
wjones127 merged 1 commit intolance-format:mainfrom Dec 3, 2024
Merged
Conversation
yanghua
force-pushed
the
3185-spotless-maven-plugin
branch
from
d43de3a to
580ed88
Compare
Collaborator
Author
|
In Java CI, when running If there is any code style issue, it will break the mvn command. The CI will fail. Users or developers can use In addition, we could also introduce git pre-commit-hook to make developers run this command before submitting a PR. I believe, by introducing this plugin, the community will have a pleasing codebase. However, yes, it's unfortunate we need a one-shot reformat to initialize it. cc @LuQQiu , FYI: Apache Iceberg, Flink, Kyuubi, and Hudi have all adopted this plugin. |
wjones127
changed the title
wjones127
approved these changes
Dec 3, 2024
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
This seems reasonable to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.