ci: update python/Cargo.log on version bump#3207
Merged
wjones127 merged 1 commit intolance-format:mainfrom Dec 6, 2024
Merged
Conversation
…ew lance versions on version bump
wjones127
approved these changes
Dec 5, 2024
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
Thank you for looking into this 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we create the version bump commit it currently updates the lock file
Cargo.lockto point to the new versions. I suspect it is thecargo ws version --no-git-commit -y --exact --force 'lance*' ${{ inputs.part }}command that does this. However, we have two lock files, andpython/Cargo.lockis not updated. This PR adds a step to the version bump to also updatepython/Cargo.lock.