feat: support between sql clauses#3225
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3225 +/- ##
==========================================
+ Coverage 78.45% 78.53% +0.07%
==========================================
Files 244 245 +1
Lines 84554 84998 +444
Branches 84554 84998 +444
==========================================
+ Hits 66333 66749 +416
- Misses 15418 15431 +13
- Partials 2803 2818 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I took a look and the good news is that your code all seems right. The bad news was that Datafusion was rewriting the BETWEEN into a pair of <= and >= operators anyways 😆 So I went ahead and added the optimization in the scalar index parsing to detect anything that looks like a between and make sure we are collapsing into a single query. |
|
Feel free to test this out and let me know if it helps your original issue. |
… that looks like a between query and use the between correctly. Minor formatting changes.
47ac915 to
725f9fa
Compare
This adds support for the sql
col BETWEEN x AND yclause