fix: test failure in test_fsl_packed_struct#3227
Merged
broccoliSpicy merged 2 commits intolance-format:mainfrom Dec 10, 2024
Merged
fix: test failure in test_fsl_packed_struct#3227broccoliSpicy merged 2 commits intolance-format:mainfrom
test_fsl_packed_struct#3227broccoliSpicy merged 2 commits intolance-format:mainfrom
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
test_fsl_packed_structtest_fsl_packed_struct
test_fsl_packed_structtest_fsl_packed_struct
westonpace
approved these changes
Dec 10, 2024
Member
|
Code looks fine but fix conventional commits CI failure |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3227 +/- ##
==========================================
+ Coverage 78.45% 78.48% +0.03%
==========================================
Files 244 245 +1
Lines 84554 84815 +261
Branches 84554 84815 +261
==========================================
+ Hits 66333 66564 +231
- Misses 15418 15439 +21
- Partials 2803 2812 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current main has test failure in
test_fsl_packed_structbecause I introduced statistics gathering forStructDataBlock, but not statistics gathering inFixedSizeListDataBlock.To fix this test, I can add statistics gathering(in this case, only
Stat::MaxLengthis needed) forFixedSizeListDataBlock.I think the variants of
FixedSizeList's child datablockcan only be eitherfixed width datablockor anotherfixed size list?This PR however only disables the packed struct encoding test for
fixed size list.after reading https://docs.rs/arrow-array/53.3.0/src/arrow_array/array/fixed_size_list_array.rs.html#133, it looks like that the child of a
fixed size listcan be any array type, which means to supportMaxLengthstatistics forfixed size list data block, we need to haveMaxLengthstatistics for all otherdatablocktypes.