feat: break stream by max bytes param#3435
feat: break stream by max bytes param#3435SaintBacchus wants to merge 2 commits intolance-format:mainfrom
Conversation
| } | ||
|
|
||
| if num_rows_in_current_file >= params.max_rows_per_file as u32 | ||
| || writer.as_mut().unwrap().tell().await? >= params.max_bytes_per_file as u64 |
There was a problem hiding this comment.
This tell() always returns 0 since the writer has not called the finish()
5a99535 to
997404a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3435 +/- ##
==========================================
- Coverage 78.46% 78.46% -0.01%
==========================================
Files 252 252
Lines 93917 94032 +115
Branches 93917 94032 +115
==========================================
+ Hits 73696 73778 +82
- Misses 17226 17262 +36
+ Partials 2995 2992 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d94d166 to
ad8d375
Compare
format fix some ut fix some ut 1G to 90G ignore one test case try fix something format refactor 1 2 3 4 5
6900734 to
b595aa6
Compare
|
If we use the average size to estimate the memory usage, it's not accurate. |
Did you see this https://docs.rs/arrow/latest/arrow/array/struct.ArrayData.html#method.get_slice_memory_size ? |
|
I had missed this method. I will test it later. |
try to fix #3393