feat: add gcp token-based auth support#3511
Merged
changhiskhan merged 2 commits intolance-format:mainfrom Mar 6, 2025
Merged
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3511 +/- ##
==========================================
+ Coverage 78.46% 78.66% +0.20%
==========================================
Files 252 254 +2
Lines 93917 94999 +1082
Branches 93917 94999 +1082
==========================================
+ Hits 73692 74731 +1039
- Misses 17230 17249 +19
- Partials 2995 3019 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3b4153b to
c66d048
Compare
c66d048 to
1a18b8d
Compare
chebbyChefNEQ
approved these changes
Mar 6, 2025
alex766
added a commit
to alex766/lance
that referenced
this pull request
Mar 12, 2025
eddyxu
pushed a commit
that referenced
this pull request
Mar 26, 2025
after #3511, we discovered that we also needed support for setting the token through environment variables, so this sets storage options with the "google_storage_token" env variable --------- Co-authored-by: Alexandra Li <alexandra.li@databricks.com>
Jay-ju
pushed a commit
to Jay-ju/lance
that referenced
this pull request
Mar 28, 2025
after lance-format#3511, we discovered that we also needed support for setting the token through environment variables, so this sets storage options with the "google_storage_token" env variable --------- Co-authored-by: Alexandra Li <alexandra.li@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow support of connecting to GCP with storage tokens instead of service key JSON or serialized key using object_store's with_credentials.
Tested and created dataset in GCP:


through notebook: