perf: improve 4bit PQ performance#3557
Merged
BubbleCal merged 5 commits intolance-format:mainfrom Mar 22, 2025
Merged
Conversation
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
…4bit-pq Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3557 +/- ##
==========================================
+ Coverage 78.81% 78.91% +0.10%
==========================================
Files 256 256
Lines 95958 96546 +588
Branches 95958 96546 +588
==========================================
+ Hits 75625 76193 +568
- Misses 17265 17284 +19
- Partials 3068 3069 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wjones127
approved these changes
Mar 21, 2025
| // compute the distances for first k_hint rows | ||
| // then use the max distance as qmax to quantize the distance table | ||
| let k_hint = min(k_hint, num_vectors); | ||
| let flat_num = max(200, k_hint).min(num_vectors); |
Contributor
There was a problem hiding this comment.
Would be nice to leave a comment about why 200 was selected here.
Contributor
Author
There was a problem hiding this comment.
added comments for this
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this also fixes a bug that the
AddAssignimpl for u8x16 is not saturated