Skip to content

feat: add JNI bindings for the file reader/writer#3588

Merged
westonpace merged 3 commits intolance-format:mainfrom
westonpace:feat/java-file-reader
Mar 24, 2025
Merged

feat: add JNI bindings for the file reader/writer#3588
westonpace merged 3 commits intolance-format:mainfrom
westonpace:feat/java-file-reader

Conversation

@westonpace
Copy link
Copy Markdown
Member

No description provided.

@westonpace westonpace requested a review from LuQQiu March 23, 2025 15:27
@github-actions github-actions Bot added enhancement New feature or request java labels Mar 23, 2025
@westonpace westonpace requested a review from eddyxu March 23, 2025 15:27
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 1.30293% with 303 lines in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (f02095d) to head (e9b796a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
java/core/lance-jni/src/file_reader.rs 0.00% 136 Missing ⚠️
java/core/lance-jni/src/file_writer.rs 0.00% 97 Missing ⚠️
rust/lance-file/src/v2/reader.rs 3.44% 56 Missing ⚠️
java/core/lance-jni/src/error.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3588      +/-   ##
==========================================
- Coverage   78.86%   78.69%   -0.17%     
==========================================
  Files         256      258       +2     
  Lines       96493    96847     +354     
  Branches    96493    96847     +354     
==========================================
+ Hits        76095    76215     +120     
- Misses      17329    17561     +232     
- Partials     3069     3071       +2     
Flag Coverage Δ
unittests 78.69% <1.30%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eddyxu eddyxu requested a review from jmhsieh March 23, 2025 19:00
@jmhsieh
Copy link
Copy Markdown
Contributor

jmhsieh commented Mar 23, 2025

the java code and test lgtm. I don't trust myself in rust yet.

@westonpace westonpace merged commit 9dbb06a into lance-format:main Mar 24, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants