Skip to content

fix: work around deranged breaking change not labeled as such#3591

Merged
westonpace merged 1 commit intolance-format:mainfrom
westonpace:fix/avoid-ambiguous-impl-deranged
Mar 24, 2025
Merged

fix: work around deranged breaking change not labeled as such#3591
westonpace merged 1 commit intolance-format:mainfrom
westonpace:fix/avoid-ambiguous-impl-deranged

Conversation

@westonpace
Copy link
Copy Markdown
Member

A breaking change was introduced in jhpratt/deranged#18 which was not given a semver bump. As a result we pick it up and it fails the "no lock file" test.

This PR just avoids the try_into entirely since it doesn't seem to be necessary (we only work on 64-bit machines so usize->u64 should be safe).

@github-actions github-actions Bot added the bug Something isn't working label Mar 24, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.93%. Comparing base (db72d25) to head (65e7167).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3591   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files         256      256           
  Lines       96481    96481           
  Branches    96481    96481           
=======================================
+ Hits        76160    76161    +1     
+ Misses      17258    17251    -7     
- Partials     3063     3069    +6     
Flag Coverage Δ
unittests 78.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@westonpace westonpace merged commit 32c99af into lance-format:main Mar 24, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants