fix: work around deranged breaking change not labeled as such#3591
Merged
westonpace merged 1 commit intolance-format:mainfrom Mar 24, 2025
Merged
Conversation
…a new version of a downstream crate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3591 +/- ##
=======================================
Coverage 78.93% 78.93%
=======================================
Files 256 256
Lines 96481 96481
Branches 96481 96481
=======================================
+ Hits 76160 76161 +1
+ Misses 17258 17251 -7
- Partials 3063 3069 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eddyxu
approved these changes
Mar 24, 2025
wjones127
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A breaking change was introduced in jhpratt/deranged#18 which was not given a semver bump. As a result we pick it up and it fails the "no lock file" test.
This PR just avoids the try_into entirely since it doesn't seem to be necessary (we only work on 64-bit machines so usize->u64 should be safe).