Skip to content

fix: divide by 0 error if remapping PQ storage to empty#3596

Merged
BubbleCal merged 4 commits intolance-format:mainfrom
BubbleCal:fix-pq-remap
Mar 25, 2025
Merged

fix: divide by 0 error if remapping PQ storage to empty#3596
BubbleCal merged 4 commits intolance-format:mainfrom
BubbleCal:fix-pq-remap

Conversation

@BubbleCal
Copy link
Copy Markdown
Contributor

@BubbleCal BubbleCal commented Mar 25, 2025

this fixes:

  • divide by 0 error if remapping an empty PQ storage
  • 4bit PQ panic if there are less than 16 rows

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions Bot added the bug Something isn't working label Mar 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal changed the title fix: PQ storage divide by 0 error if remapping to empty fix: divide by 0 error if remapping PQ storage to empty Mar 25, 2025
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal marked this pull request as ready for review March 25, 2025 08:25
Copy link
Copy Markdown
Contributor

@wkalt wkalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@BubbleCal BubbleCal merged commit eb4680e into lance-format:main Mar 25, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants