Skip to content

fix(java): correct version number for java module when create tag#3597

Closed
yanghua wants to merge 1 commit intolance-format:mainfrom
yanghua:issue-3593
Closed

fix(java): correct version number for java module when create tag#3597
yanghua wants to merge 1 commit intolance-format:mainfrom
yanghua:issue-3593

Conversation

@yanghua
Copy link
Copy Markdown
Collaborator

@yanghua yanghua commented Mar 25, 2025

No description provided.

@yanghua yanghua self-assigned this Mar 25, 2025
@github-actions github-actions Bot added the bug Something isn't working label Mar 25, 2025
@yanghua
Copy link
Copy Markdown
Collaborator Author

yanghua commented Mar 25, 2025

@eddyxu May I ask why we do not create a release branch for a major.minor e.g. release-0.24, or release-0.25?

Using current mode, I find it hard to apply the -SNAPSHOT practice. Because, if we have a release branch, it should remove the -SNAPSHOT in that branch, while currently, we always evolute in the main branch.

IMO, using current mode, it's hard to maintain compatibility for a major.minor series versions.

@westonpace
Copy link
Copy Markdown
Member

I like this fix better than #3600 . I hope you don't mind if I merge it.

@westonpace westonpace reopened this Mar 25, 2025
@yanghua yanghua marked this pull request as ready for review March 26, 2025 02:11
@yanghua
Copy link
Copy Markdown
Collaborator Author

yanghua commented Mar 26, 2025

@westonpace If you want, I do not mind. Some clarification:

  • The changes were not tested; it would be better to test them before merging, but I do not know if the whole workflow can be a dry run.
  • if we use this change, the master will generate this commit sequence: Update Java module versions -> Bump up version.. If we do not have a release branch, it looks strange, but it should works.

@westonpace
Copy link
Copy Markdown
Member

Ah, yeah, from testing I think the commit will be a problem because it isn't pushed. I'm going to go back to dropping the snapshot for now so I can get the release out. We can maybe change the publish job to look at the tag, and if it's a release, add SNAPSHOT back in. That being said, I think @wjones127 wanted to change lance's release process to look more like lancedb's release process at some point and that might support this better.

IMO, using current mode, it's hard to maintain compatibility for a major.minor series versions.

Do you mean backporting fixes? That's something we haven't really done a lot of historically since we don't have the bandwidth. We do tag releases so we can always create branches from those tags manually if needed for some reason.

@yanghua
Copy link
Copy Markdown
Collaborator Author

yanghua commented Mar 26, 2025

Do you mean backporting fixes? That's something we haven't really done a lot of historically since we don't have the bandwidth.

Yes, understand.

In the future, We may encounter a scenario where one fix only applies to the current branch, but not to main. At that time, the branch-based release is better to deal with this problem.

@yanghua yanghua closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants