fix: set maximan 8 target partitions for merge insert update fragments#3603
Merged
LuQQiu merged 2 commits intolance-format:mainfrom Mar 26, 2025
Merged
fix: set maximan 8 target partitions for merge insert update fragments#3603LuQQiu merged 2 commits intolance-format:mainfrom
LuQQiu merged 2 commits intolance-format:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
==========================================
+ Coverage 78.65% 78.69% +0.03%
==========================================
Files 258 258
Lines 96782 96897 +115
Branches 96782 96897 +115
==========================================
+ Hits 76126 76255 +129
+ Misses 17588 17571 -17
- Partials 3068 3071 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
westonpace
reviewed
Mar 26, 2025
| if options.target_partition.is_some() { | ||
| return new_session_context(options); | ||
| } | ||
| if options.mem_pool_size() == DEFAULT_LANCE_MEM_POOL_SIZE { |
Member
There was a problem hiding this comment.
Minor nit: the changes to this method could be simplified if you changed this line to:
if options.mem_pool_size() == DEFAULT_LANCE_MEM_POOL_SIZE && options.target_partition.is_none() {
westonpace
approved these changes
Mar 26, 2025
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Great! Thanks for looking into this
Jay-ju
pushed a commit
to Jay-ju/lance
that referenced
this pull request
Mar 28, 2025
lance-format#3603) fixes lance-format#3601 More info can be find in the lance-format#3601 For merge_insert, the partition number does not affect the memory size required by each partition but affect the memory size that is available for this partition. Limit the target partitions to 8 or CPU cores to reduce the chance of hitting Resources exhausted during merge insert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3601
More info can be find in the #3601
For merge_insert, the partition number does not affect the memory size required by each partition but affect the memory size that is available for this partition.
Limit the target partitions to 8 or CPU cores to reduce the chance of hitting Resources exhausted during merge insert