Skip to content

fix: fix python format#3608

Merged
wjones127 merged 2 commits intolance-format:mainfrom
Jay-ju:format_python
Mar 28, 2025
Merged

fix: fix python format#3608
wjones127 merged 2 commits intolance-format:mainfrom
Jay-ju:format_python

Conversation

@Jay-ju
Copy link
Copy Markdown
Contributor

@Jay-ju Jay-ju commented Mar 26, 2025

When I execute "make format-python" every time for the Python code in the current main branch, there will always be format errors reported for these few files. So here, I want to correct the format here.

@westonpace @wjones127 Help review it.

@github-actions github-actions Bot added bug Something isn't working python labels Mar 26, 2025
@LuQQiu
Copy link
Copy Markdown
Contributor

LuQQiu commented Mar 26, 2025

Hey @Jay-ju, if you're looking to ensure consistent Python formatting, it's better to add it to the build pipeline directly — like in the python.yml workflow
Otherwise, formatting fixes might not persist across PRs.

@wjones127
Copy link
Copy Markdown
Contributor

Yeah I think we need to modify:

https://github.com/lancedb/lance/blob/5891b1ad50c4d418c41a07be1a6fe713e2ce78c8/.pre-commit-config.yaml#L2-L3

and
https://github.com/lancedb/lance/blob/a53f27a1b728d638109f3f78b8a0635ab6153368/.github/workflows/python.yml#L60

To an updated ruff version.

I'm fine if we update to the latest. But agree we want CI to have a matching version.

@Jay-ju Jay-ju force-pushed the format_python branch 2 times, most recently from 3311e13 to fd7f8da Compare March 28, 2025 06:57
@Jay-ju
Copy link
Copy Markdown
Contributor Author

Jay-ju commented Mar 28, 2025

Yeah I think we need to modify:

https://github.com/lancedb/lance/blob/5891b1ad50c4d418c41a07be1a6fe713e2ce78c8/.pre-commit-config.yaml#L2-L3

and

https://github.com/lancedb/lance/blob/a53f27a1b728d638109f3f78b8a0635ab6153368/.github/workflows/python.yml#L60

To an updated ruff version.

I'm fine if we update to the latest. But agree we want CI to have a matching version.

@wjones127 Is there anything that needs to be set up separately for the CI process here? After I update, there is no formatting issue locally, but the CI pipeline will report an error.

@wjones127 wjones127 merged commit 82f6560 into lance-format:main Mar 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants