Merged
Conversation
Contributor
|
Hey @Jay-ju, if you're looking to ensure consistent Python formatting, it's better to add it to the build pipeline directly — like in the python.yml workflow |
Contributor
|
Yeah I think we need to modify: To an updated ruff version. I'm fine if we update to the latest. But agree we want CI to have a matching version. |
3311e13 to
fd7f8da
Compare
Contributor
Author
@wjones127 Is there anything that needs to be set up separately for the CI process here? After I update, there is no formatting issue locally, but the CI pipeline will report an error. |
wjones127
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I execute "make format-python" every time for the Python code in the current main branch, there will always be format errors reported for these few files. So here, I want to correct the format here.
@westonpace @wjones127 Help review it.